Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omero admin start: add warning for deprecated TLS protocols #382

Merged
merged 3 commits into from
Oct 3, 2023
Merged

omero admin start: add warning for deprecated TLS protocols #382

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bbc9b0
omero admin start: add warning for deprecated TLS protocols
sbesson Aug 25, 2023
0659f4e
Use ConfigXml getter to access SSL Protocols value
sbesson Aug 26, 2023
8c5b661
Use relevant anchor to the server certificate section
sbesson Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/omero/plugins/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,22 @@ def startasync(self, args, config):
"sysadmins/server-performance.html?highlight=poolsize\n"
"for more information.")

# Warn if deprecated TLS 1.0 and 1.1 protocols are allowed
# See https://datatracker.ietf.org/doc/html/rfc8996
# Both protocols are included in the default value of IceSSL.Protocols
# https://doc.zeroc.com/ice/3.6/property-reference/icessl#id-.IceSSL.*v3.6-IceSSL.Protocols
DEPRECATED_TLS_MESSAGE = (
"Your server is configured to allow a deprecated TLS protocol."
"\n\nPlease refer to https://omero.readthedocs.io/en/stable/"
"sysadmins/server-upgrade.html#server-certificates for "
"instructions on how to upgrade your configuration.")
try:
ssl_protocols = config["omero.glacier2.IceSSL.Protocols"]
if ("TLS1_0" in ssl_protocols or "TLS1_1" in ssl_protocols):
self.ctx.out("WARNING: " + DEPRECATED_TLS_MESSAGE)
except KeyError:
self.ctx.out("WARNING: " + DEPRECATED_TLS_MESSAGE)

self._initDir()
# Do a check to see if we've started before.
self._regdata()
Expand Down