Build #15
Merged
Build #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Dec 16, 2024
setup.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| install_requires=[ | |||
| 'omero-py>=5.6.0', | |||
| # TODO: Update to current release 0.7.* | |||
| 'prometheus-client==0.2.*', | |||
There was a problem hiding this comment.
Given the note above, what are the implications of uncapping this dependency?
In particular:
- are there some backwards-incompatible changes since version 0.2.x that would modify the usage of the library?
- as the upstream library is still sub-1.0.0, should it be capped to protect from future changes?
There was a problem hiding this comment.
I will try to see what happened when I re-introduced the cap, it might have been introduced when attempting to fix the initial issue
sbesson
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update actions and Update PyPI publish workflow to use build instead of sdist