Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omero-cli-zarr submodule #329

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

will-moore
Copy link
Member

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@will-moore
Copy link
Member Author

Presumably this PR doesn't change anything (and there isn't a build to test it) so nothing happens until it's merged, right?

@jburel jburel merged commit 48cba64 into ome:master Dec 15, 2023
@joshmoore
Copy link
Member

Presumably this PR doesn't change anything (and there isn't a build to test it) so nothing happens until it's merged, right?

The merge build would have picked it up and "done the right thing".

@will-moore
Copy link
Member Author

If I search recent build https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-plugins-push/342/console for omero-cli-zarr I see this PR was merged, but I don't see that it has made a merge build of omero-cli-zarr and pushed it to https://github.com/snoopycrimecop/omero-cli-zarr (since that is still 404)?

@joshmoore
Copy link
Member

Hmmm... surprising. I would have thought it would have created it. But I didn't look into the snoopy repo at the time. Now it exists though, so all's well. Worst case, we merge these type of submodule additions proactively as here. 👍

@will-moore will-moore deleted the omero-cli-zarr_submodle branch December 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants