Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic header detection tests #72

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

muhanadz
Copy link
Member

@muhanadz muhanadz commented Apr 8, 2022

Added test for the new automatic column type (header) detection behavior from #67. The test will create an example CSV inclusive of the different combinations a user can use in a temp location which is passed into the new detect_headers function. The output is then checked with the expected output of said columns.

This would be a good place to start when we want to change the behavior of the automatic detection (eg column plate_id should be detected as type plate instead of the current l)

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few suggestions of extra tests to cover all the scenarios introduced in #67.

I would also propose to migrate the file under test/unit/test_automatic_header.py as it does not require a working OMERO.server/omero-test-infra infrastructure.

test/integration/detection/test_automatic_header.py Outdated Show resolved Hide resolved
test/integration/detection/test_automatic_header.py Outdated Show resolved Hide resolved
test/integration/detection/test_automatic_header.py Outdated Show resolved Hide resolved
@sbesson sbesson merged commit faccb0e into ome:master Apr 15, 2022
@muhanadz muhanadz deleted the test_automatic_detection branch April 25, 2022 11:16
@sbesson sbesson mentioned this pull request May 18, 2022
@sbesson sbesson added this to the 0.11.0 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants