Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ontology loads #377

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix ontology loads #377

wants to merge 12 commits into from

Conversation

sukunis
Copy link
Member

@sukunis sukunis commented Jul 20, 2023

Improve ontology label retrieval by replacing RESTAPI's with a Sparql query to the Sparql endpoint http://sparql.hegroup.org/sparql/

--exclude

@jburel jburel force-pushed the fix_ontologyLoads branch from b1cd365 to 32a2ef7 Compare August 18, 2023 09:59
@ome ome deleted a comment from snoopycrimecop Aug 18, 2023
@ome ome deleted a comment from snoopycrimecop Aug 18, 2023
@joshmoore joshmoore requested a review from jburel October 18, 2023 11:23
(see https://github.com/SmartDataAnalytics/jena-sparql-api)
*/
public class OntologyParser_sparql {
private String default_sparqlEndpoint="http://sparql.hegroup.org/sparql/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should set in the config file so we do not have to recompile if the endpoint changes

}

public List<OntologyElement>getSubLabels(String ontologyAcronym, String ontologyRef){
System.out.println("####Run query for Acronym: "+ontologyAcronym+", Ref: "+ontologyRef);
Copy link
Member

@jburel jburel Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be removed

@snoopycrimecop snoopycrimecop mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants