Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relative reference when it does not work #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pwalczysko
Copy link
Member

@pwalczysko pwalczysko commented Jul 7, 2022

Removing the variable insight_version in 4 places where it does not resolve.
Interestingly:

This is also motivated by ome/omero-guides#56

cc @jburel @joshmoore

@jburel
Copy link
Member

jburel commented Jul 7, 2022

We should figure why it does not resolve.

@pwalczysko
Copy link
Member Author

We should figure why it does not resolve.

No chance to debug this. See the description. I cannot repeat the problem locally in sufficient granularity. The variable either resolves locally on all occassions (when built from this repo) or it does not resolve on any occassion (when built from omero-guides). But on production omero-guides, it resolves on 2 cases out of 4 and it does not resolve in the other 2 cases. The warning must be where the production version is built, but I do not know where that is ?

@jburel
Copy link
Member

jburel commented Jul 8, 2022

is it a side effect of the mix of submodules (github) and subprojects (rtd)

@pwalczysko
Copy link
Member Author

How to progress on this one ?

@jburel
Copy link
Member

jburel commented Jul 12, 2022

I did not have a chance to look at it.
Ideally I would like to avoid the suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants