Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scm version fix #159

Merged
merged 2 commits into from
Jan 19, 2024
Merged

scm version fix #159

merged 2 commits into from
Jan 19, 2024

Conversation

will-moore
Copy link
Member

Use version_file instead of write_to for scm_version

As a breaking change in https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md#v800
is "introduce version_file as replacement for write_to".

This PR makes the corresponding change.

@joshmoore
Copy link
Member

Re-opening to trigger the job since this looks very much unrelated:

    fatal: unable to access 'https://github.com/ome/omero-cli-zarr/': The requested URL returned error: 500

@joshmoore joshmoore closed this Jan 9, 2024
@joshmoore joshmoore reopened this Jan 9, 2024
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find, @will-moore! More than happy to backburner versioneer, then.

@will-moore
Copy link
Member Author

will-moore commented Jan 9, 2024

In testing locally, with pip install . from source, the initial change above didn't help (after deleting the .eggs/ dir etc).
The simplest fix that did work for me so far was to pin setuptools_scm:

setup_requires=["setuptools_scm==7.1.0"],

@will-moore
Copy link
Member Author

will-moore commented Jan 9, 2024

With that 2nd commit, things are working as before for me locally.
I can pip install -e . and everything works.

In the short term, if others are happy, I'd like to simply get that fix in and release, possibly including #147 (although that could also come in a follow-up release).

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#366. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Jan 11, 2024

Conflicting PR. Removed from build OMERO-plugins-push#367. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-plugins-push#368. See the console output for more details.

@will-moore
Copy link
Member Author

@joshmoore I think this is now conflicting with your versionneer PR #156.
Could you maybe close that for now and see if we can get this fix in? Thanks

@joshmoore
Copy link
Member

👍 Done.

@will-moore
Copy link
Member Author

@joshmoore @jburel Any objections to getting this merged and released (would be good to get a release that isn't broken)?

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran into the error:

configparser.DuplicateOptionError: While reading from '<???>' [line 41]: option 'versions.' in section 'DEFAULT' already exists

and following your pinning strategy in ome/omero-marshal#78 fixed the issue, @will-moore. But I'd strongly urge us to find a better solution soon (i.e. a follow issue), but no blocker for this PR from my side.

@will-moore will-moore merged commit 59d66e1 into ome:master Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants