-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scm version fix #159
scm version fix #159
Conversation
Re-opening to trigger the job since this looks very much unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the find, @will-moore! More than happy to backburner versioneer, then.
In testing locally, with
|
With that 2nd commit, things are working as before for me locally. In the short term, if others are happy, I'd like to simply get that fix in and release, possibly including #147 (although that could also come in a follow-up release). |
Conflicting PR. Removed from build OMERO-plugins-push#366. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-plugins-push#367. See the console output for more details.
|
@joshmoore I think this is now conflicting with your versionneer PR #156. |
👍 Done. |
@joshmoore @jburel Any objections to getting this merged and released (would be good to get a release that isn't broken)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also ran into the error:
configparser.DuplicateOptionError: While reading from '<???>' [line 41]: option 'versions.' in section 'DEFAULT' already exists
and following your pinning strategy in ome/omero-marshal#78 fixed the issue, @will-moore. But I'd strongly urge us to find a better solution soon (i.e. a follow issue), but no blocker for this PR from my side.
Use version_file instead of write_to for scm_version
As a breaking change in https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md#v800
is "introduce
version_file
as replacement forwrite_to
".This PR makes the corresponding change.