Refactor Config and ROCrateWriter #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code was complicated by the need to keep up with a config, a store, a path and a subpath for both the input & the output. This combines all four parameters into a single class so that only two instances need passing. Functionality has been moved into instance methods where possible to reduce leakage, though more refactoring could be applied.
|
Merging for 0.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current resave.py was getting fairly complicated. This PR introduces two new classes to help control that complexity:
Config: this encapsulates all the issues regarding reading/writing from local/remote storage for zarr/tensorstore.ROCrateWriter: this is an extension point that we can add to in order to read metadata from other sources. Currently it only takes the 5 known parameters from the command-line.This branch is currently based on #17 awaiting @dominikl's review.
cc: @sherwoodf @will-moore