-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bioformats2raw metadata support #174
Draft
joshmoore
wants to merge
22
commits into
ome:master
Choose a base branch
from
joshmoore:implicit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+688
−9
Draft
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d132636
Add Implicit spec to loop over metadata-less "collections"
joshmoore 7470587
Add Leaf & Root specs
joshmoore 8a4603e
Add support for entrypoint `ome_zarr.spec`
joshmoore 02f88c9
Also add entrypoints to requirements-dev.txt
joshmoore 9824efe
Minor doc improvements
joshmoore 6ae6355
Disable Root/Leaf specifiations
joshmoore 9ad2e5a
Load all requirements for the zarr-dev build
joshmoore 42065e5
Migrate bioformats2raw spec
joshmoore ed464ac
Add ome-types dependency
joshmoore 2344751
Remove traces of ome_zarr_metadata
joshmoore 8735307
Add ome-types for pre.yml
joshmoore d42b530
Store series information
joshmoore 4a98669
Add tests
joshmoore e3d7364
Merge 'origin/master' into implicit
joshmoore 5c86762
Add placeholder for bf2raw reading in docs
joshmoore d954ba2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5105916
Fix build issues
joshmoore 28155d5
Update documentation
joshmoore eb12b2b
Attempt to fix pre.yml
joshmoore 6962d49
TMP implicit
joshmoore 08b14b8
Merge remote-tracking branch 'origin/master' into implicit
joshmoore 836dfd2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
black | ||
cython >= 0.29.16 | ||
numpy >= 1.16.0 | ||
entrypoints | ||
pre-commit | ||
tox | ||
wheel | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? I see no file named
"ome_zarr.spec"
and I've not usedentrypoints
before. I don't get much idea from https://github.com/takluyver/entrypoints as to what it does, only that "This package is in maintenance-only mode. New code should use theimportlib.metadata module
".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's essentially a namespace for the particular entrypoint. It's used at
https://github.com/ome/ome-zarr-metadata/blob/main/setup.cfg#L81