Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify: other axis type values should be strings #270

Closed
wants to merge 1 commit into from

Conversation

imagejan
Copy link
Contributor

For axis types that are not space, time or channel, the JSON schema only allows string values:

"type": {
"type": "string",
"not": {
"enum": ["space", "time", "channel"]
}
}

The language in the spec however didn't specify this so far. Let's explicitly specify that other values must be strings.

Copy link
Contributor

Automated Review URLs

joshmoore added a commit to normanrz/ngff that referenced this pull request Nov 22, 2024
@joshmoore
Copy link
Member

Thanks, @imagejan! Because of the current build failures, I've pulled these changes into #242 (and applied to the upcoming 0.5 version)

@joshmoore joshmoore closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants