Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-1: author response #258

Merged
merged 25 commits into from
Sep 11, 2024
Merged

RFC-1: author response #258

merged 25 commits into from
Sep 11, 2024

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Aug 30, 2024

Just barely in time to have met my summer goal of replying to the reviews of RFC-1, I'm opening this update to the RFC process proposal. There is likely some need for clarifications before the changes are merged and sent out for re-review (R1). I would ask interested members of the community two favors:

A. Endorsements (easier)

Since the first version of RFC-1 in #222 did not exist in order to request endorsements, I did not request them. Now that RFC-2 and RFC-3 along with #253 and #254 (a.k.a. RFC-4 and RFC-5) have successfully demonstrated the joy of endorsing RFCs, I would ask anyone who supports RFC-1 to add an emoji below. (Instructions provided)

B. Clarifications (bit more work)

Additionally, if you would like to give a careful read of the document and identify anything that is confusing, illogical, or otherwise to be avoided, I'd appreciate the additional eyes. You are additionally welcome to submit an additional, long-form Comment. (Examples are in the built webpages: https://ngff--258.org.readthedocs.build/rfc/1/comments/)

Reviewers are of course welcome to be involved in the clarifications, but need not do so.


⚠️ Emojis on this PR will be considered for endorsements:

  • 👍🏽 ❤️ 🚀 😄 🎉 -- you will be listed on the RFC as an endorser.
  • 👎🏽 ☹️ -- I will contact you regarding how you would like to express your objection.
  • 👀: no special meaning

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Automated Review URLs

rfc/1/index.md Outdated Show resolved Hide resolved
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/ngff-rfc-process-proposal-draft-now-available/90181/3

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked up a couple of typos...

rfc/1/index.md Outdated Show resolved Hide resolved
rfc/1/responses/1/index.md Outdated Show resolved Hide resolved
rfc/1/responses/1/index.md Outdated Show resolved Hide resolved
rfc/1/responses/1/index.md Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member Author

Thanks, all, for the endorsements. One last call for endorsements or other clarifications before I send this out for re-review.

@joshmoore joshmoore merged commit d2216ef into ome:main Sep 11, 2024
9 checks passed
@joshmoore joshmoore deleted the rfc-1-response branch September 11, 2024 07:13
github-actions bot added a commit that referenced this pull request Sep 11, 2024
RFC-1: author response

SHA: d2216ef
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joshmoore joshmoore mentioned this pull request Sep 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants