Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operetta reader: don't add directories to the used files list #4248

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

melissalinkert
Copy link
Member

Backported from a private PR.

Without this change, and with an extra directory in the Operetta/Phenix plates hierarchy like this:

/path/to/plate_name/images/index.xml
/path/to/plate_name/eval/ID/file.csv

showinf should report the directory /path/to/plate_name/eval/ID on the used files list, but not any of the files it contains.
Including directories on the used file list causes problems when importing to OMERO.

This change should remove any directories from the used files list, but will not recursively look for files in any unexpected directories - so /path/to/plate_name/eval/ID/file.csv would still not appear on the list.

@melissalinkert melissalinkert added this to the 8.1.0 milestone Oct 21, 2024
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the code level, the proposed changes add some defensive checks to the reader which should handle subdirectories similarly to what was done for the CV7000 reader #3982.

Would it be possible to construct and configure a synthetic plate reproducing the issue and add it to the curated OME QA repository?

@melissalinkert
Copy link
Member Author

See curated/perkinelmer-operetta/samples/extra-directories, as noted in https://github.com/openmicroscopy/data_repo_config/pull/625.

@melissalinkert melissalinkert modified the milestones: 8.1.0, 8.0.1 Nov 4, 2024
@sbesson sbesson merged commit e32024e into ome:develop Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants