Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testSaneUsedFiles: check getCurrentFile is the first file in the getUsedFiles list #4172

Merged
merged 2 commits into from
Nov 4, 2024
Merged

testSaneUsedFiles: check getCurrentFile is the first file in the getUsedFiles list #4172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35fdbb3
testSaneUsedFiles: check getCurrentFile is the first file in the getU…
sbesson Mar 25, 2024
0fc32a5
testSaneUsedFiles: exclude readers with getCurrentFile/used file mism…
sbesson Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions components/test-suite/src/loci/tests/testng/FormatReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,10 +1866,22 @@ public void testSaneUsedFiles() {
msg = "Used files list contains duplicates";
}

if (base.length == 1) {
if (!base[0].equals(file)) success = false;
if (!(reader.getFormat().equals("Bio-Rad PIC")) &&
!(reader.getFormat().equals("Metamorph STK")) &&
!(reader.getFormat().equals("Evotec Flex")) &&
!(reader.getFormat().equals("CellSens VSI")) &&
!(reader.getFormat().equals("PerkinElmer")) &&
!(reader.getFormat().equals("Fuji LAS 3000")) &&
!(reader.getFormat().equals("Micro-Manager")) &&
!(reader.getFormat().equals("BDV")) &&
!(reader.getFormat().equals("Zeiss AxioVision TIFF")) &&
!(reader.getFormat().equals("Olympus ScanR")) &&
!base[0].equals(file)) {
success = false;
msg = "Used files list does not start with getCurrentFile";
}
else if (success) {

if (success) {
Arrays.sort(base);
IFormatReader r =
/*config.noStitching() ? new ImageReader() :*/ new ImageReader();
Expand Down