CZI: fix image naming, especially for attachments #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 failure in the nightly repo tests: https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/45331/consoleFull |
dgault
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Builds and tests are all green with this and the config PR included. The code changes all look good from my side.
Looking at the config PR and all of the new unflattened names look good and match the expected values based on the acquisition type. Also manually tested the sample files from QA-20612, GH-2791 and GH-3710. Without the PR the macro and label images were mis labelled. With the PR included they are now correctly labelled.
NicoKiaru
added a commit
to BIOP/quick-start-czi-reader
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4103. Makes use of the new image name test from #4114.
A configuration PR is forthcoming that demonstrates affected data. For datasets with changed names, compare the name and actual image with and without this PR to verify that this fixes label and macro naming. Multi-scene and plate data should also now have unflattened names that reflect the acquisition type, instead of just
Scene #1etc.