Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate org.json:json dependency declaration #4125

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Dec 6, 2023

Implements #4123 (review)

Since org.json:json is now a dependency of formats-bsd, this removes the duplicate declaration in formats-gpl so that the version is only managed in one place.

An alternative would be to declare json.version as a top-level property

Since org.json:json is now a dependency of formats-bsd, this removes
the duplicate declaration in formats-gpl so that the version is
only managed in one place
@dgault dgault added this to the 7.1.0 milestone Dec 7, 2023
Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to simply remove it rather than having it declared it both components

@dgault dgault merged commit 48563cb into ome:develop Dec 7, 2023
17 checks passed
@sbesson sbesson deleted the json_remove_duplicate branch December 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants