Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIR: channel order and missing pixel block fixes #4111

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

melissalinkert
Copy link
Member

Backported from a private PR.

Changes through line 742 were meant to address a single missing pixel block issue. Unfortunately, the data for that case is private and I have not successfully made an artificial example that demonstrates the problem.

The remainder of the changes are meant to address an issue with channel ordering. The problem occurs when the primary channel elements (whose order attributes were respected) are deemed invalid, and the secondary channel elements are used instead. The changes here update the secondary channel element handling in parseChannel to respect the order attribute, so that both sets of channel handling logic match. An artificial example that demonstrates is in curated/olympus-oir/samples/channel-reorder.

@jburel jburel requested a review from dgault December 15, 2023 11:56
@jburel
Copy link
Member

jburel commented Dec 15, 2023

@melissalinkert Will the testing data we currently have be enough for review or do we need a new set of data?

@sbesson sbesson added this to the 7.2.0 milestone Dec 18, 2023
@sbesson sbesson self-requested a review December 18, 2023 22:18
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested with the artificial sample generated to simulate the channel order scenario as well as the private samples.

With this PR included, the channel returned match the screenshots from the Olympus Viewer plugin. No other regression was raised as part of the nightly CI builds and the new sample file has been configured appropriately.

Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the channel ordering using the new artificial sample file. With the PR included the channel ordering for the new sample file matches that from the description of the config PR. All other builds and tests have remained green with this PR included.

@dgault dgault merged commit 077ed12 into ome:develop Jan 12, 2024
17 checks passed
@melissalinkert melissalinkert deleted the oir-image-fixes-develop branch September 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants