OIR: channel order and missing pixel block fixes #4111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from a private PR.
Changes through line 742 were meant to address a single missing pixel block issue. Unfortunately, the data for that case is private and I have not successfully made an artificial example that demonstrates the problem.
The remainder of the changes are meant to address an issue with channel ordering. The problem occurs when the primary channel elements (whose
order
attributes were respected) are deemed invalid, and the secondary channel elements are used instead. The changes here update the secondary channel element handling inparseChannel
to respect theorder
attribute, so that both sets of channel handling logic match. An artificial example that demonstrates is incurated/olympus-oir/samples/channel-reorder
.