TIFF: check IFD entry offset before seeking #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when using artifical 64-bit offsets. This is identical to the check that occurs when using the file's native offset width. Fixes ome#3941
dgault
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Tested using the sample files from curated/hamamatsu/imagesc-76590 and curated/hamamatsu/imagesc-86248
Without the Pr I was seeing the same exceptions as originally reported:
Exception in thread "main" java.lang.IllegalArgumentException: newLimit > capacity: (1858100467 > 5)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:388)
at java.base/java.nio.Buffer.limit(Buffer.java:362)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1322)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:266)
at loci.common.NIOFileHandle.read(NIOFileHandle.java:309)
at loci.common.NIOFileHandle.read(NIOFileHandle.java:298)
at loci.common.NIOFileHandle.read(NIOFileHandle.java:286)
at loci.common.RandomAccessInputStream.read(RandomAccessInputStream.java:681)
at loci.formats.tiff.TiffParser.getIFDValue(TiffParser.java:566)
at loci.formats.tiff.TiffParser.fillInIFD(TiffParser.java:526)
at loci.formats.in.MinimalTiffReader.initFile(MinimalTiffReader.java:483)
at loci.formats.in.BaseTiffReader.initFile(BaseTiffReader.java:609)
at loci.formats.in.NDPIReader.initFile(NDPIReader.java:311)
at loci.formats.FormatReader.setId(FormatReader.java:1466)
With the PR included the exception was not seen and the file was able to be opened and displayed as expected. All builds and repo tests have remained green with this PR and the config PR included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3941 (I think).
showinf -noflat -resolution 6on each of 3 affected files referenced in #3941 works with this PR, but does not work without this PR. The forthcoming configuration PR will include NDP.view2 screenshots for reference; it's worth noting that all 3 affected files have 3 Z sections.Assuming tests pass, should be safe for a patch release.