Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.1.0 API updates #349

Merged
merged 5 commits into from
Dec 11, 2023
Merged

7.1.0 API updates #349

merged 5 commits into from
Dec 11, 2023

Conversation

dgault
Copy link
Member

@dgault dgault commented Dec 6, 2023

Adding documentation for the new CV7000 reader option and the 2 new bfconvert options.

@dgault dgault added this to the 7.1.0 milestone Dec 6, 2023
@dgault dgault requested a review from melissalinkert December 6, 2023 15:55
Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me apart from a couple of minor comments.

sphinx/users/comlinetools/conversion.rst Show resolved Hide resolved

Enables the writing of additional supplemental metadata from an external file during the conversion process .
Most output formats do not support this option, currently this is implemented for outputting the DICOM format.
For DICOM the additional metadata file can be in the format of a .dcdump or .json file ::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .dcdump provider was removed before ome/bioformats#4016 was merged, so only .json is accepted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, removed in latest commit

@dgault dgault merged commit 6c869ad into ome:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants