Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another DeprecationWarning, and a bug in _is_expired #151

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix another DeprecationWarning, and a bug in _is_expired #151

merged 4 commits into from
Oct 2, 2024

Commits on Oct 1, 2024

  1. add a test for the format of _get_expires_at

    @npt
    npt committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3851ee7 View commit details
    Browse the repository at this point in the history

  2. remove use of utcnow(), deprecated in Python 3.12

    @npt
    npt committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9dcc952 View commit details
    Browse the repository at this point in the history

  3. Fix a bug in timezone parsing in _is_expired 

    Previously, _is_expired would raise
    TypeError: can't compare offset-naive and offset-aware datetimes
if passed a (string representing a) datetime with a timezone.
    @npt
    npt committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bf2b5c4 View commit details
    Browse the repository at this point in the history

  4. in test, use an ISO format that Python <3.11 will accept

    @npt
    npt committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d0a4eb2 View commit details
    Browse the repository at this point in the history