Do not expliclity type generated schemas #64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some features from the generated schemas. For example, `ZodType` lacks features from `ZodObject` such as `.pick`, or `.merge`.
|
Indeed, some things got broken. If you try the generated schemas with tRPC, you would face this error(among others):
So, until we found a solution for that problem, we can't really merge this PR sadly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing them explicitly with
ZodTyperemoves some features from the generated schemas.For example,
ZodTypelacks features fromZodObjectsuch as.pick, or.merge.Others have stumbled upon this issue as well, for example, #24 and #25 bring this up. In #25 (comment) someone brings up that the change I made broke something in the generator for them.
In my case, nothing broke - but this could of course have unwanted side effects. In my understanding,
ZodObjectextendsZodType, which reduces the risk of issues.But I am really not sure about this.