Fix issue with run_setup and dronecan

[tmcadam]

This is very rough, but demonstrates a fix for the issue with dronecan failing in run_setup.py

• Creates a python virtual environment in the mLRS/common/dronecan folder.
• Installs the dependencies
• Runs the dronecan steps with the python executable from virtual env

ONLY TESTED ON LINUX!

[jlpoltrack]

Brilliant - confirming it worked for me on MacOS.

[olliw42]

oh my gosh ... that's really above my head ... and since I guess I have to maintain that scrupt "scares" me ...
we really need that?
I mean, it's super elegangt and professional, but ... over the top of my head ...

[tmcadam]

Hmmm, this is actually an unusual way of doing it, but it keeps it all in a python script, and keeps it cross-platform. I guess other option is to replace to run_setup.py with run_setup.bat(windows) and run_setup.sh(linux mac). These shell scripts can install the dronecan dependencies and run the other python scripts, that would be the more common way of doing it.

Last option is to just document the installation steps for the 4 python dependencies before running run_setup.py and let devs do it themselves. I think you still need to setup python virtual environment for this, the more recent versions of python seem to increasingly severe warnings on system-wide dependency installation.

[olliw42]

@tmcadam
I'm looking at this again as the underlying issue really needs a solution and your approach looks quite nice (and I start to feel more comfortable as venv's become more familiar to me :))

One question though I find confusing:
When I run a test code with import venv venv.create(xxx) I do get a 'Scripts' folder but not a 'bin' folder?
Why is that, why do we get different folders hosting the python.exe?
Is that an os thing, or what?

[tmcadam]

@olliw42

https://stackoverflow.com/questions/43826134/why-is-the-bin-directory-named-differently-scripts-on-windows

It looks like a windows mac/linux thing. I can't remember but likely I was using linux when I created this PR.

[Hyperion218]

During initialization of mLRS repo on my computers (windows & linux), I stumbled on the same issue that this PR resolve.
I've added a small change proposition that should resolve OS specific weirdness on folder names.

[Hyperion218]

To resolve the issue of differents folder name containing python between Unix/MAC and Windows OS, same-ish code as in the original virtualenv commit (here) can be used.

Suggested change

	python_path = os.path.join(venv_folder, "bin", "python")
	bin_dir = "bin"
	if sys.platform == 'win32':
	bin_dir = "Scripts"
	python_path = os.path.join(venv_folder, bin_dir, "python")