Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component registration updated #268

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

vikas-cldcvr
Copy link
Collaborator

@vikas-cldcvr vikas-cldcvr commented Apr 29, 2024

Checklist for raising a PR

  • Gone through UX documnetation for adding new features.
  • All necessary unit tests covered.
  • Required comments added for generating component manifest file? you can find details here
  • Did you check the contributing doc?
  • Did you check the existing issues for similar queries?

Describe your PR

@ollion/flow-core

[3.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-code-editor

[2.0.0] - 2024-04-20

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-form-builder

[3.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-lineage

[4.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-log

[3.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-md-editor

[3.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@ollion/flow-table

[3.0.0] - 2024-04-29

Major/Breaking Changes

  • Auto web component registration was removed to facilitate tree shaking.
  • To register component manually please check here

@vikas-cldcvr vikas-cldcvr marked this pull request as ready for review April 29, 2024 15:32
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

/// <reference types="vite/client" />

import { ConfigUtil } from "@ollion/flow-core-config";
import { version } from "../package.json";
import { LitElement } from "lit";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think barrel files are not handled when doing tree shaking https://vitejs.dev/guide/performance#avoid-barrel-files

We should try enabling sideEffects option in package.json and check if Vite can tree shake unused components - https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try publishing a beta version, and check if vite handles this correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants