ollama-python: enable passing messages with "control" role to enable granite3.2 thinking control functionality #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ollama's python client currently only permits messages with roles of either 'user', 'assistant', 'system', or 'tool'.
As described here - ollama/ollama#8955 (comment) - this prevents sending messages with the "control" role, which was introduced by IBM's granite3.2 to enable turning the "thinking" functionality on and off as needed.
This pull request adds "control" to the list of valid values for a message's "role" field/attribute so that these messages can be passed through to ollama.
Note: ollama server already handles messages with this role appropriately, but the python client currently does not allow sending them to ollama server. This resolves the issue in the python client.