Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support appsync subscription #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lowecg
Copy link

@lowecg lowecg commented Nov 11, 2024

As mentioned in issue #98, here are the changes necessary to support subscriptions with AppSync.

@oliyh
Copy link
Owner

oliyh commented Nov 12, 2024

Hi,

Thanks for this! I really appreciate the contribution. Do you know if the "subscriptions as data" is a common pattern, or is it something unique to Appsync? My inclination is to have something like an implementation "flavour" called Appsync, which would take care of any aspects unique to Appsync. The impl parts were intended more as a way of exposing the underlying transport libraries to empower users if they needed to tweak something at the transport level, but I see Appsync as more of a protocol thing.

What do you think?

Cheers

@lowecg
Copy link
Author

lowecg commented Nov 15, 2024

Thank you for reviewing this, Oli.

I was trying to be agnostic in the naming of "subscription as data", but I'm not sure if it is a common pattern so the AppSync flavour makes sense. Noted on the usage of impl. I'll have a think about this and will put forward some changes this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants