Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: account info and public-only events #254

Merged
merged 2 commits into from
May 14, 2018
Merged

Auth: account info and public-only events #254

merged 2 commits into from
May 14, 2018

Conversation

osteele
Copy link
Contributor

@osteele osteele commented May 14, 2018

Description

3683e56 Closes #214 A client should be able to find out whether it's authenticated

c3353a4 Completes #75 An unauthenticated client should not receive non-public events

Required

Changes must conform to these requirements:

  • python -m unittest passes. All new and existing tests pass.
  • flake8 abe tests *.py passes. All new code follows the code style of this project.

Specific

These only apply if your changes touch certain areas of the project:

  • API changes are documented with swagger. (Not all the API is covered yet)
  • New env variables are added to .env.template

Aspirational

We don't yet require these, but they are nice to have:

  • New code is covered by new or existing tests.
  • Changed code is covered by new or existing tests.

@osteele osteele merged commit 2caed03 into dev May 14, 2018
@osteele osteele deleted the osteele/auth branch May 14, 2018 18:39
@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #254 into dev will increase coverage by 0.38%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #254      +/-   ##
==========================================
+ Coverage   66.44%   66.83%   +0.38%     
==========================================
  Files          22       23       +1     
  Lines        1207     1224      +17     
==========================================
+ Hits          802      818      +16     
- Misses        405      406       +1
Impacted Files Coverage Δ
abe/helper_functions/query_helpers.py 89.79% <ø> (ø) ⬆️
abe/resource_models/account_resources.py 100% <100%> (ø)
abe/app.py 89.58% <100%> (+0.45%) ⬆️
abe/resource_models/event_resources.py 62.39% <62.5%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3902819...c3353a4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant