BSO Wildy Changes #5926
Merged
BSO Wildy Changes #5926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellipsis-dev review this pr |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃憤 Looks good to me! Reviewed everything up to 916b1d3 in 2 minutes and 5 seconds
More details
- Looked at
164lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_VlWhiNbL3cswIByn
You can customize Ellipsis with 馃憤 / 馃憥 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the requirement of equipping items in the wildy gear slot to get the relevant boost (with the exception of the hellfire boost)
Follows on from the poll here - https://discord.com/channels/342983479501389826/1032668754561224734/1252665746614390829
Summary:
Removed the requirement for equipping items in the wilderness gear slot for boosts, except for the Hellfire boost, and updated relevant functions and files accordingly.
Key points:
src/lib/minions/data/killableMonsters/custom/demiBosses.tsto setcanBePkedforMalygosandTreebeard.src/mahoji/lib/abstracted_commands/minionKill.tsto remove wilderness gear checks inapplyDragonBoost,applyBlackMaskBoost,calculateSalveAmuletBoost, and other relevant functions.resolveAvailableItemBoostsinsrc/mahoji/mahojiSettings.tsto removeisInWildernessparameter and related checks.Generated with 鉂わ笍 by ellipsis.dev