Implement Clone trait for CircuitBuilder #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doutv
commented
Apr 18, 2024
Comment on lines
+107
to
+109
| pub trait WitnessGenerator<F, const D: usize>: 'static + Send + Sync + Debug + DynClone | ||
| where | ||
| F: RichField + Extendable<D>, |
There was a problem hiding this comment.
add DynClone trait requirement
doutv
commented
Apr 18, 2024
Comment on lines
+128
to
135
| dyn_clone::clone_trait_object!(<F, const D: usize> WitnessGenerator<F, D> where F: RichField + Extendable<D>); | ||
|
|
||
| /// A wrapper around an `Box<WitnessGenerator>` which implements `PartialEq` | ||
| /// and `Eq` based on generator IDs. | ||
| #[derive(Clone)] | ||
| pub struct WitnessGeneratorRef<F: RichField + Extendable<D>, const D: usize>( | ||
| pub Box<dyn WitnessGenerator<F, D>>, | ||
| ); |
There was a problem hiding this comment.
dyn_clone::clone_trait_object! Implement Clone trait for WitnessGenerator
Then WitnessGeneratorRef can automatically derive Clone trait
doutv
commented
Apr 18, 2024
Cargo.toml
Outdated
Comment on lines
6
to
8
| cryptography_cuda = { git = "ssh://[email protected]/okx/cryptography_cuda.git", rev = "d44b861cf241d27688525e7a8f082199a2abcbfa", features = [ | ||
| "no_cuda", | ||
| ] } |
There was a problem hiding this comment.
Also, I add cryptography_cuda to workspace.dependencies
Used in zkdex-plonky2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/okx/zkdex-plonky2-circom-poc/pull/72
In order to implement Clone trait for CircuitBuilder, the key is to implement Clone for its member
WitnessGeneratorRefSince WitnessGenerator is a dynamic trait, containing lots of generators. I use https://github.com/dtolnay/dyn-clone to do it.
See more: https://stackoverflow.com/a/50785548/22481384