Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit maxtxcount perpeer for dev #3268

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

BananaLF
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

* limit tx count of per peer

* remove useles code

* change code location

* can not limit tx count when limit == 0
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6b97af6) 36.54% compared to head (2e27f29) 36.54%.

❗ Current head 2e27f29 differs from pull request most recent head d9e0eec. Consider uploading reports for the commit d9e0eec to get more accurate results

Files Patch % Lines
app/config/config.go 25.00% 8 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3268      +/-   ##
==========================================
- Coverage   36.54%   36.54%   -0.01%     
==========================================
  Files         446      446              
  Lines       46857    46869      +12     
==========================================
+ Hits        17123    17126       +3     
- Misses      28463    28471       +8     
- Partials     1271     1272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjianmeng xiangjianmeng merged commit 3fdc51e into dev Dec 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants