Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of incorrectly assigning err when trace tx #3198

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

LeoGuo621
Copy link
Contributor

@LeoGuo621 LeoGuo621 commented Jul 8, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@LeoGuo621 LeoGuo621 requested a review from ylsGit July 8, 2023 00:14
@codecov-commenter
Copy link

Codecov Report

Merging #3198 (00d224c) into dev (808531f) will increase coverage by 0.00%.
The diff coverage is 14.28%.

❗ Current head 00d224c differs from pull request most recent head a3f9c97. Consider uploading reports for the commit a3f9c97 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3198   +/-   ##
=======================================
  Coverage   36.54%   36.54%           
=======================================
  Files         443      443           
  Lines       46498    46499    +1     
=======================================
+ Hits        16994    16995    +1     
  Misses      28238    28238           
  Partials     1266     1266           
Impacted Files Coverage Δ
x/evm/types/state_transition.go 64.22% <14.28%> (+0.14%) ⬆️

@KamiD KamiD merged commit ec7f814 into dev Jul 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants