pruning without batch #2944
Open
pruning without batch #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a79c1da)
lyh169
previously approved these changes
Feb 9, 2023
giskook
reviewed
Feb 11, 2023
| @@ -710,11 +754,18 @@ func (ndb *nodeDB) getPreviousVersion(version int64) int64 { | |||
| } | |||
|
|
|||
| // deleteRoot deletes the root entry from disk, but not the node it points to. | |||
| func (ndb *nodeDB) deleteRoot(batch dbm.Batch, version int64, checkLatestVersion bool) { | |||
| func (ndb *nodeDB) deleteRoot(batch dbm.Batch, version int64, checkLatestVersion bool, writeToDB bool) { | |||
There was a problem hiding this comment.
Maybe we can rename writeToDB a better name. batch is writeToDB too ;P
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #2944 +/- ##
=======================================
Coverage 36.20% 36.20%
=======================================
Files 428 428
Lines 44828 44828
=======================================
+ Hits 16230 16232 +2
+ Misses 27425 27424 -1
+ Partials 1173 1172 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a79c1da)
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: