Skip to content

Commit

Permalink
Merge PR: fix ut (#2382)
Browse files Browse the repository at this point in the history
* immutable height -1

* logic

* move codes
  • Loading branch information
ItsFunny authored Jul 30, 2022
1 parent c4811e4 commit 53f449a
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions libs/cosmos-sdk/store/iavl/iavl_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ func getHeight(tree Tree, req abci.RequestQuery) int64 {
height := req.Height
if height == 0 {
latest := tree.Version()
_, err := tree.GetImmutable(latest)
if err != nil {
_, err := tree.GetImmutable(latest - 1)
if err == nil {
height = latest - 1
} else {
height = latest
Expand All @@ -318,16 +318,17 @@ func (st *Store) Query(req abci.RequestQuery) (res abci.ResponseQuery) {
// store the height we chose in the response, with 0 being changed to the
// latest height
res.Height = getHeight(st.tree, req)
tree, err := st.tree.GetImmutable(res.Height)
if err != nil {
return sdkerrors.QueryResult(sdkerrors.Wrapf(iavl.ErrVersionDoesNotExist, "request height %d", req.Height))
}

switch req.Path {
case "/key": // get by key
key := req.Data // data holds the key bytes
res.Key = key

tree, err := st.tree.GetImmutable(res.Height)
if err != nil {
return sdkerrors.QueryResult(sdkerrors.Wrapf(iavl.ErrVersionDoesNotExist, "request height %d", req.Height))
}

if req.Prove {
value, proof, err := tree.GetWithProof(key)
if err != nil {
Expand Down

0 comments on commit 53f449a

Please sign in to comment.