Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to read .okta.yaml config file from working directory #382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ConnorWidtfeldt
Copy link

Summary

The documentation makes it sound like the expected behavior regarding the .okta.yaml file is to read it from the applications directory. This, however, tries to read the config file from the shared library when not building statically. Instead of patching this behavior, in case somebody depends on it, I have added another check to try to load the config file from the applications working directory.

Fixes #349

Type of PR

  • Bug Fix (non-breaking fixes to existing functionality)
  • New Feature (non-breaking changes that add new functionality)
  • Documentation update
  • Test Updates
  • Other (Please describe the type)

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I ran make fmt on my code
  • I did not edit any automatically generated files

@github-actions
Copy link

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.

@github-actions github-actions bot added the stale label Jun 29, 2023
@monde monde removed the stale label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.

Copy link

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.

@github-actions github-actions bot added the stale label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration is not read from the .okta.yaml file in the application or project's root directory
3 participants