-
Notifications
You must be signed in to change notification settings - Fork 623
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor the feedback widget (#4239)
Feedback JS resources no longer passively load on each page hit.
- Loading branch information
1 parent
3b669b4
commit 5d3f002
Showing
14 changed files
with
97 additions
and
51 deletions.
There are no files selected for viewing
25 changes: 0 additions & 25 deletions
25
packages/@okta/vuepress-plugin-qualtrics-feedback/enhanceAppFile.js
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
packages/@okta/vuepress-plugin-qualtrics-feedback/package.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/@okta/vuepress-theme-prose/assets/css/components/_feedback.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* QUALTRICS FEEDBACK WIDGET */ | ||
#feedback-tab { | ||
position: fixed; | ||
|
||
right: 0; | ||
bottom: 158px; | ||
|
||
width: 36px; | ||
height: 139px; | ||
|
||
overflow: hidden; | ||
|
||
background-color: #242424; | ||
} | ||
|
||
#feedback-link { | ||
display: inline-block; | ||
width: 100%; | ||
height: 100%; | ||
} | ||
|
||
#feedback-container { | ||
transform: translate(0,70px); | ||
} | ||
|
||
#feedback-text { | ||
transform: rotate(270deg); | ||
|
||
font-size: 1em; | ||
font-family: "arial", sans-serif; | ||
color: #ffffff; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
packages/@okta/vuepress-theme-prose/components/Feedback.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<template> | ||
<div id="feedback-tab"> | ||
<a | ||
id="feedback-link" | ||
href="#" | ||
title="Submit feedback" | ||
@click="openSurvey()" | ||
> | ||
<div id="feedback-container"> | ||
<p id="feedback-text">Feedback</p> | ||
</div> | ||
</a> | ||
</div> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'Feedback', | ||
methods: { | ||
openSurvey() { | ||
window.open('https://surveys.okta.com/jfe/form/SV_e4L0iW8a3tz8Yol?source=' + encodeURIComponent(document.location.href), '_blank'); | ||
} | ||
} | ||
} | ||
</script> |
8 changes: 5 additions & 3 deletions
8
packages/@okta/vuepress-theme-prose/global-components/EventHookEANote.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 5 additions & 3 deletions
8
packages/@okta/vuepress-theme-prose/global-components/EventHookEANoteProcedure.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import MainPage from '../page-objects/MainPage'; | ||
|
||
describe('feedback widget sanity check', () => { | ||
const mainPage = new MainPage(); | ||
|
||
beforeEach( () => { | ||
mainPage.visit('/test_page/'); | ||
}); | ||
|
||
it('validate feedback widget', () => { | ||
const widget = mainPage.getFeedbackWidget(); | ||
widget.should('be.visible'); | ||
widget.find('#feedback-link') | ||
.should('have.attr', 'href') | ||
.and('include', '#') | ||
.and('not.contain', 'https://surveys.okta.com'); | ||
}); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7971,10 +7971,10 @@ json-stringify-safe@~5.0.1: | |
resolved "https://registry.yarnpkg.com/json-stringify-safe/-/json-stringify-safe-5.0.1.tgz#1296a2d58fd45f19a0f6ce01d65701e2c735b6eb" | ||
integrity sha1-Epai1Y/UXxmg9s4B1lcB4sc1tus= | ||
|
||
[email protected].3, json5@^1.0.1, json5@^2.1.2, json5@^2.2.1: | ||
version "2.2.3" | ||
resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.3.tgz#78cd6f1a19bdc12b73db5ad0c61efd66c1e29283" | ||
integrity sha512-XmOWe7eyHYH14cLdVPoyg+GOH3rYX++KpzrylJwSW98t3Nk+U8XOl8FWKOgwtzdb8lXGf6zYwDUzeHMWfxasyg== | ||
[email protected].2, json5@^1.0.1, json5@^2.1.2, json5@^2.2.1: | ||
version "2.2.2" | ||
resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.2.tgz#64471c5bdcc564c18f7c1d4df2e2297f2457c5ab" | ||
integrity sha512-46Tk9JiOL2z7ytNQWFLpj99RZkVgeHf87yGQKsIkaPz1qSH9UczKH1rO7K3wgRselo0tYMUNfecYpm/p1vC7tQ== | ||
|
||
jsonfile@^4.0.0: | ||
version "4.0.0" | ||
|
5d3f002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acrolinx Scorecards
Acrolinx checked the content changed here.
Please review the scorecards for each file and make the recommended
improvements.
Successfully checked 1 of 1 documents.
See summary in Content Analysis Dashboard
Reopen the pull request or push new changes to check again.
Depending on the Acrolinx server configuration, the
links expire after some time and you must have a login for the
Acrolinx server to access them again.