Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use accounts-password and newer bcrypt #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adammoisa
Copy link

Fixes node-gyp rebuild console error with bycrpt

@Exoool
Copy link

Exoool commented Aug 22, 2016

@adammoisa
With my local project, I had to use the version of 0.9.1 instead of 0.8.x.
Later I tried with get rid of the version number completely - and it works just fine by going defaut to v0.9.1.

Any idea about the drawbacks without specifying the version number?

@adammoisa
Copy link
Author

@Exoool I unfortunately don't know the details of the bcrypt version differences, I guess do whatever works for you, a later version is (usually considered) better. If you come across a unique bug with versioning please let the community know!

@Exoool
Copy link

Exoool commented Aug 23, 2016

@adammoisa Sure, it was the same bug whatsoever - just wasn't sure if it's perfectly ok to remove the version number. But now as it works in reality so I guess it's just fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants