-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish i18n initial integration #691
Conversation
I just checked and the local build in Linux looks great and the translations work perfectly... I noticed the error report translations are missing, but this we knew already, but this line here is also missing: https://github.com/okfn/opendataeditor/blob/main/client/components/Views/Report/Table.tsx#L30 where it says 'Row number', could you add this translation? |
Deploying opendataeditor with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Evgeny!! It looks great! Just one small comment. Is it possible to remove the text "language" at the top of the bottom (if this is not pre-defined, of course).
I think it would be better so that all text from features there are the same. Again, if this is not possible, let's merge it.
I checked dialogs, buttons and everything looks OK.
@romicolman Let's discuss the label on the planning. It might be better to keep it because I think it's a requirement regarding accessibility that all the input have to have corresponding labels. |
Ok, perfect! Let's merge it for now :) |
@romicolman
A next step would be creating a follow-up issue that covers: