fix: search button doesn't have an accessible name #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search button doesn't have an accessible name. That's because the `aria-hidden="true"`-HTML-attribute is set on the wrong HTML-tag, and should get moved to the preceding icon tag it's most likely meant for (compare to other places in the code like e.g. https://github.com/search?q=repo%3Aokfde%2Ffragdenstaat_de%20fa-search&type=code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search button doesn't have an accessible name. That's because the
aria-hidden="true"-HTML-attribute is set on the wrong HTML-tag, and should get moved to the preceding icon tag it's most likely meant for (compare to other places in the code like e.g. https://github.com/search?q=repo%3Aokfde%2Ffragdenstaat_de%20fa-search&type=code).