Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add font option & implement toggle side panel #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eefahd
Copy link

@eefahd eefahd commented Jun 21, 2018

1- Add the option to change the font style.
2- Implement toggle side panel function.
3- Fix Arabic file names problem.

2- Implement toggle side panel function.
3- Fix Arabic file names problem.
@muayyad-alsadi
Copy link
Member

thank you for your contribution, I'll merge this pull request ASAP.

although it does not alight with my vision to the UI.
I want less buttons in the toolbar and more buttons in the burger menu.

when I have time, I'll merge this and move the actions to the burger menu after the merge.

@eefahd
Copy link
Author

eefahd commented Jun 24, 2018

Hi Muayyad,
Thank you for your reply.
I agree with you, the toolbar should be clean and have only the options that users always use like page navigation. So, I did not add any item to the toolbar, I only added the font style changing option in the burger menu.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants