Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port flatfield #81

Closed
wants to merge 2 commits into from
Closed

Port flatfield #81

wants to merge 2 commits into from

Conversation

astrobc1
Copy link
Contributor

@astrobc1 astrobc1 commented Sep 1, 2024

@zonca test_flat.py is good to go. I deleted the jupyter notebooks in f378964.

Copy link
Member

@zonca zonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that there is a change in Iris readout?
Make sure that there is no change in that.

@@ -1,2 +1,2 @@
test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test file left?
If not, we can replace this with pytest -v without specifying any file

@zonca
Copy link
Member

zonca commented Sep 2, 2024

Also rebase on master before merging

@zonca
Copy link
Member

zonca commented Sep 2, 2024

implemented the 3 small fixes mentioned here (iris_readout, makefile and rebasing) in #82 to avoid messing up your branch. It worked fine, so I am merging #82 and closing this.

@zonca zonca closed this Sep 2, 2024
@zonca zonca mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants