Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate issue with datamodels.open #68

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Investigate issue with datamodels.open #68

merged 6 commits into from
Jul 23, 2024

Conversation

zonca
Copy link
Member

@zonca zonca commented Jul 3, 2024 •
edited
Loading

Investigating #60,
no need to review, no need to merge for now.

@zonca
Copy link
Member Author

zonca commented Jul 3, 2024

Error is:

FAILED liger_iris_pipeline/tests/test_dark.py::test_dark_step - TypeError: expected str, bytes or os.PathLike object, not LigerIrisDataModel

@zonca zonca self-assigned this Jul 19, 2024
@zonca zonca requested a review from astrobc1 July 22, 2024 01:45
@zonca
Copy link
Member Author

zonca commented Jul 22, 2024

@astrobc1 I have not found a solution for this.
So for now I think the best is to do a better workaround.

So with this base class we can use the same fix in other steps.

@zonca zonca marked this pull request as ready for review July 22, 2024 01:47
@zonca zonca mentioned this pull request Jul 22, 2024
Merged
@astrobc1 astrobc1 linked an issue Jul 22, 2024 that may be closed by this pull request
datamodels.open does not work on a datamodel #60
Closed
@astrobc1 astrobc1 mentioned this pull request Jul 22, 2024
Closed
@zonca zonca merged commit e5358b6 into master Jul 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrobc1 astrobc1 Awaiting requested review from astrobc1

Assignees

@zonca zonca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datamodels.open does not work on a datamodel
1 participant
@zonca