Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamodels.open does not work on a datamodel #60

Open
zonca opened this issue Jun 23, 2024 · 0 comments
Open

datamodels.open does not work on a datamodel #60

zonca opened this issue Jun 23, 2024 · 0 comments

Comments

@zonca
Copy link
Member

zonca commented Jun 23, 2024

The workaround is this commit:

701a431

this is triggered by get_reference_file, see below for more details. It seems like JWST has no issues passing a Data model to get_reference_file, however, it seems we can only pass a string. We need to understand where this issue is coming from.

  • 701a431 I see how this stems from an assumption that get_reference_file expects a filename, not a DataModel. Should we override get_reference_file to accept both?

There is something I do not understand here, maybe you can track it down,
see here:
https://github.com/spacetelescope/jwst/blob/10501f22def0460b15df65cd5261601c6a71d7cf/jwst/dark_current/dark_current_step.py#L32

they are doing the same, feeding the input model to get_reference_file, why does it work for them and not for us?
I think that at some point in the class hierarchy we are using different classes but have not understood where.

Originally posted by @zonca in #58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant