Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Contact link does not work properly in the footer #38

Closed
wants to merge 10 commits into from
Closed

Fix: Contact link does not work properly in the footer #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
527e631
Fixed scrolling bug
AdityaJ2305 Dec 10, 2024
88baa5a
Fix: clicking on contact take to contact section
AdityaJ2305 Dec 12, 2024
1b9dda4
updated to scroll for home page
AdityaJ2305 Dec 13, 2024
bccbb3f
testing on deployment
AdityaJ2305 Dec 15, 2024
824f29c
console log to check
AdityaJ2305 Dec 15, 2024
d5bed66
console log to check
AdityaJ2305 Dec 15, 2024
4dc391f
removed console log
AdityaJ2305 Dec 15, 2024
91c728b
trying removing onClick
AdityaJ2305 Dec 15, 2024
312c2ce
remove useeffect
AdityaJ2305 Dec 25, 2024
1a93b38
remove useeffect
AdityaJ2305 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export default function Footer() {
];

return (
<footer className="bg-primary-100 mt-20">
<footer className="bg-primary-100 mt-20" id="contact">
<div className="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 py-12">
<div className="grid grid-cols-1 lg:grid-cols-[1fr,auto,auto] gap-8 lg:gap-16">
<div className="max-w-sm">
Expand Down
4 changes: 0 additions & 4 deletions components/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,9 @@ export default function Header(props: { fixed?: boolean }) {
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
if (path === item.page) {
document
.getElementById(item.id)
?.scrollIntoView({ behavior: "smooth" });
} else {
router.push(item.page + "#" + item.id);
}
}}
>
{item.content}
Expand Down
1 change: 0 additions & 1 deletion pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,6 @@ export default function Home() {
</section>
<CommitLayout>{null}</CommitLayout>
<section
id="contact"
aria-label="Join Our Open Healthcare Network Slack Community"
>
<div className="mx-auto max-w-7xl px-4 sm:px-6 lg:px-8">
Expand Down