Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert supported browsers command to a script #8564

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 18, 2024

This PR refactors the existing command for generating supported browsers into a dedicated script. The new script utilizes the browserslist-useragent-regexp package to generate the user agent regex and writes it directly to the supportedBrowsers.ts file.

@sainak sainak requested a review from a team as a code owner September 18, 2024 14:30
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 54db3f4
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66ec20cb82844e0008d2570d
😎 Deploy Preview https://deploy-preview-8564--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sainak sainak marked this pull request as draft September 18, 2024 14:36
Copy link

cypress bot commented Sep 18, 2024

CARE    Run #3407

Run Properties:  status check passed Passed #3407  •  git commit 54db3f4fe0: Convert supported browsers command to a script
Project CARE
Branch Review sainak/fix/supported-browsers
Run status status check passed Passed #3407
Run duration 04m 18s
Commit git commit 54db3f4fe0: Convert supported browsers command to a script
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@sainak sainak marked this pull request as ready for review September 19, 2024 13:01
@khavinshankar khavinshankar merged commit c9ed04e into develop Sep 19, 2024
26 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/supported-browsers branch September 19, 2024 13:50
Copy link

@sainak @sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants