Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide sensitive user data for non admin users #8458

Closed
wants to merge 3 commits into from
Closed

Hide sensitive user data for non admin users #8458

wants to merge 3 commits into from

Conversation

khavinshankar
Copy link
Member

Proposed Changes

Depends on: ohcnetwork/care#2222

@ohcnetwork/care-fe-code-reviewers

@khavinshankar khavinshankar requested a review from a team as a code owner September 2, 2024 12:00
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

❌ Deploy Preview for care-ohc failed.

Name Link
🔨 Latest commit 0a61c3f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e9267db4da440008728908

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

Functionality looks good, fix the cypress failure

@nihal467 nihal467 added changes required cypress failed pull request with cypress test failure and removed needs testing labels Sep 2, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the stale label Sep 11, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 17, 2024
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 17, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 17, 2024

CARE    Run #3367

Run Properties:  status check failed Failed #3367  •  git commit 0a61c3f501: Hide sensitive user data for non admin users
Project CARE
Branch Review fixes#7374
Run status status check failed Failed #3367
Run duration 03m 19s
Commit git commit 0a61c3f501: Hide sensitive user data for non admin users
Committer Khavin Shankar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 122
View all changes introduced in this branch ↗︎

Tests for review

Failed  user_manage.cy.ts • 2 failed tests • UI-Chrome

View Output

Test Artifacts
Manage User > add working hour for a user and verify its reflection in card and user profile Test Replay Screenshots
Manage User > linking and unlinking facility for multiple users, and confirm reflection in user cards and doctor connect Test Replay Screenshots
Failed  UsersManage.cy.ts • 2 failed tests • UI-Chrome

View Output

Test Artifacts
Manage User > add working hour for a user and verify its reflection in card and user profile Test Replay Screenshots
Manage User > linking and unlinking facility for multiple users, and confirm reflection in user cards and doctor connect Test Replay Screenshots

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the stale label Sep 26, 2024
@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@khavinshankar can you get this merged

@github-actions github-actions bot removed the stale label Oct 8, 2024
@github-actions github-actions bot added the stale label Oct 15, 2024
@github-actions github-actions bot removed the stale label Oct 22, 2024
@khavinshankar
Copy link
Member Author

Closing this PR, will raise a new PR in place of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Carried over changes required cypress failed pull request with cypress test failure Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict needs review
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List of users- Limit Access
3 participants
@khavinshankar @nihal467 @bodhish