Solved type error using custom function

[Tanuj1718]

Proposed Changes

• Fixes Bug: Getting typeError while uploading cover photo in facility #10618
• React webcam does not contain stop function. Wrote a custom method stopCamera() to solve this issue which will explicitly stop the camera and free the resources.

Screen.Recording.2025-02-16.at.12.48.25.PM.1.mov

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• Refactor

  • Improved the avatar editing experience by refining how the camera feed is stopped for a smoother interface closure.

• Style

  • Enhanced the medication table layout to offer better responsiveness and alignment, ensuring a cleaner presentation of search inputs and controls.

[netlify]

❌ Deploy Preview for care-ohc failed.

Name	Link
🔨 Latest commit	3616b22
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b197017fa81d0008fa9908

[coderabbitai]

Walkthrough

The pull request introduces a new method, stopCamera, within the AvatarEditModal component. This method encapsulates the logic to stop the camera stream by stopping all video tracks, and it is implemented with the useCallback hook for stability. Additionally, minor cosmetic changes have been made to the MedicationRequestTable component to improve layout responsiveness by adjusting class names. No changes affect public API declarations or core functionality beyond these adjustments.

Changes

File(s)	Change Summary
src/components/Common/AvatarEditModal.tsx	Added a new stopCamera method using useCallback to encapsulate the logic for stopping the camera stream by stopping all video tracks when invoked.
src/components/Medicine/MedicationRequestTable/...	Minor layout adjustments: removed an extra space in TabsList className and added a flex-wrap class to the container of the search input and buttons.

Sequence Diagram(s)

sequenceDiagram
    actor User as User
    participant Modal as AvatarEditModal
    participant Camera as webRef (Camera Stream)
    
    User->>Modal: Click "Close Camera" Button
    Modal->>Camera: Invoke stopCamera (stop all video tracks)
    Camera-->>Modal: Camera stream halted
    Modal-->>User: Close camera interface

Loading

Possibly related PRs

• Update localization keys for photo capture to improve clarity (Follow up PR #10018) #10085: Updated localization keys for the photo capture feature in AvatarEditModal, affecting similar camera functionalities.
• Fix avatar upload stuck state and update header after changing avatar #9427: Modified the AvatarEditModal component focusing on upload functionality and error handling, overlapping with camera control logic.

Suggested labels

needs review, needs testing

Suggested reviewers

• rithviknishad
• Jacobjeevan

Poem

I'm a rabbit with a coding beat,
Hopping through changes oh so neat.
The camera now stops on a single call,
And layouts flex to please one and all.
Happy ears and a joyful code trail,
My whiskers twitch in a digital tale!
🐰💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/components/Common/AvatarEditModal.tsx (2)

89-95: LGTM! The stopCamera implementation correctly handles camera resource cleanup.

The function properly stops all video tracks and updates the component state. The use of useCallback is appropriate for maintaining a stable reference.

Consider improving type safety.

The webRef is typed as any. Consider creating a proper type for the webcam reference.

-  const webRef = useRef<any>(null);
+  type WebcamRef = {
+    video: {
+      srcObject: MediaStream | null;
+    } | null;
+    getScreenshot: () => string | null;
+    getCanvas: () => HTMLCanvasElement | null;
+  };
+  const webRef = useRef<WebcamRef>(null);

---

103-110: Consider adding camera cleanup on component unmount.

To ensure proper resource cleanup in all scenarios (e.g., when the modal is forcefully closed), consider adding the camera cleanup in a useEffect cleanup function.

+ useEffect(() => {
+   return () => {
+     stopCamera();
+   };
+ }, [stopCamera]);

 useEffect(() => {
   if (!isImageFile(selectedFile)) {
     return;
   }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21ecdf5 and 3616b22.

📒 Files selected for processing (2)

• src/components/Common/AvatarEditModal.tsx (2 hunks)
• src/components/Medicine/MedicationRequestTable/index.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/components/Medicine/MedicationRequestTable/index.tsx

🔇 Additional comments (1)

src/components/Common/AvatarEditModal.tsx (1)

411-421: LGTM! The stopCamera function is properly integrated.

The function is correctly called when closing the camera view, ensuring proper cleanup of camera resources.