Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

DriveDroid download SSL workaround #897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DriveDroid download SSL workaround #897

wants to merge 1 commit into from

Conversation

kimocoder
Copy link
Contributor

  • SoftwareBakery website's invalid SSL certificate results in error downloading DriveDroid, this is a temp. workaround NOT using SSL (https)

* SoftwareBakery website's invalid SSL certificate results in error downloading DriveDroid, this is a temp. workaround NOT using SSL (https)
@kimocoder
Copy link
Contributor Author

This issue is related to issue #856

@jcadduono
Copy link
Collaborator

I think a better long term option would be to remove the protocols (http/s) from the links and have it try only https by default, then a --insecure cmd option that will additionally try http if an https connection fails.

@kimocoder
Copy link
Contributor Author

kimocoder commented Jul 13, 2017

  • This pull request is left here to keep jcadduono's notice/comment stay here as a future "todo" work. This is a dirty solution which should not be used!

The best solution would be to add the --insecure option as mentioned in the above comment.
Feel free to implement the solution for future problems that may occour on SSL certificates.

@Re4son
Copy link
Collaborator

Re4son commented Feb 24, 2019

how about adding "--insecure" as a fallback if the first download fails?
We are comparing the hashes anyway after the download.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants