Sync with Fritz #19
Sync with Fritz #19
Conversation
Conflicts: backend/lib/DbToRia/DBI/base.pm
Conflicts: backend/lib/DbToRia/DBI/base.pm
… Application.js instead).
Conflicts: backend/lib/DbToRia/DBI/base.pm setup
Minor cleanup
| else { | ||
| print "Not source mode\n"; | ||
| } | ||
|
|
There was a problem hiding this comment.
ich finde es nicht so ideal mit dem ARGUMENT string zu spielen ... das kannst du genau so gut in einem kleinen wrapper script machen, was du ja sowoeso brauchst.
There was a problem hiding this comment.
On Wed, 19 Nov 2014, Tobias Oetiker wrote:
ich finde es nicht so ideal mit dem ARGUMENT string zu spielen ... das
kannst du genau so gut in einem kleinen wrapper script machen, was du ja
sowoeso brauchst.
Gone in qx-mojo-app branch.
| columnLabels, | ||
| columnReferences); | ||
| that.__table = new dbtoria.ui.table.Table(model, that.__tableId); | ||
| if (that.__refDelay > 0) { |
There was a problem hiding this comment.
that somehow looks like rather system dependent programming ... please explain
There was a problem hiding this comment.
The actual change against master (there the file was TableWindow.js) was actually relatively small. I had unfortunately removed the file and added a new one (TablePage.js) while the transition from the Desktop/Window setup to the Tabview/Page setup.
In the qx-mojo-app I now made the transfer clear (see TableWindow.js->TablePage.js change).
I do agree that the code in question should be better documented, but I would suggest to do that in a separate step.
Sorry for the monster pull request ... will use branches now.