Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional emission buses to facades #170

Closed
wants to merge 6 commits into from

Conversation

SabineHaas
Copy link
Member

@SabineHaas SabineHaas commented May 16, 2024

Description

Fixes #165
Adds optional emission buses to facades.

Type of change

Please tick or delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new packages are needed, I added them the setup.py
  • I have added new features/fixes to the CHANGELOG
  • I have added my name to AUTHORS

@SabineHaas SabineHaas self-assigned this May 16, 2024
@SabineHaas SabineHaas requested a review from henhuy May 16, 2024 13:22
@SabineHaas SabineHaas marked this pull request as ready for review June 17, 2024 15:54
@SabineHaas SabineHaas marked this pull request as draft July 16, 2024 12:42
@SabineHaas
Copy link
Member Author

See #180 and #177

@SabineHaas SabineHaas closed this Aug 9, 2024
@SabineHaas SabineHaas deleted the feature/facades_emission_buses branch August 9, 2024 13:39
@SabineHaas SabineHaas restored the feature/facades_emission_buses branch August 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add emissions to facades
1 participant