Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide userscript metadata that works #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide userscript metadata that works #2

wants to merge 1 commit into from

Conversation

chocolateboy
Copy link

@chocolateboy chocolateboy commented Apr 18, 2017

The default userscript metadata doesn't work, and doesn't raise an error. Add a copy 'n' pasteable stanza that works so the library can be used without diving into the source code.

  • GM_addStyle is needed for the default mode (iframe).
  • GM_registerMenuCommand is needed for the suggested menuCommand: true
    option.
  • GitHub should no longer be used as a CDN.
  • GreasyFork requires 3rd party libraries served from GitHub-mirror CDNs to have either a commit hash or a tag. In the absence of any MonkeyConfig tags/releases, use the former.

The default userscript metadata doesn't work, and doesn't raise an error.
Add a copy 'n' pasteable stanza that works so the library can be used
without diving into the source code.

* `GM_addStyle` is needed for the default mode (iframe).
* `GM_registerMenuCommand` is needed for the suggested `menuCommand: true`
  option.
* GitHub shouldn't be used as a CDN.
* GreasyFork requires 3rd party libraries served from GitHub mirror
  CDNs to have either a commit hash or a tag.
  In the absence of any MonkeyConfig tags/releases, use the former.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants