[FIX] util/fields : update field in context of custom search view #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thni-odoo
force-pushed
the
master-update_filter_context-thni
branch
from
858ee54 to
7c2fe49
Compare
thni-odoo
force-pushed
the
master-update_filter_context-thni
branch
from
7c2fe49 to
0f22f5b
Compare
|
upgradeci retry with always only hr |
aj-fuentes
reviewed
Mar 11, 2024
KangOl
requested changes
Mar 11, 2024
src/util/fields.py
Outdated
Comment on lines
65
to
66
| class _Skip(Exception): | ||
| pass |
There was a problem hiding this comment.
Avoid duplication with code in domains.py. This should be factorized and moved to records.py.
src/util/fields.py
Outdated
| @@ -1121,3 +1138,48 @@ def update_server_actions_fields(cr, src_model, dst_model=None, fields_mapping=N | |||
| ) % {"src_model": src_model, "dst_model": dst_model, "actions": ", ".join(action_names)} | |||
|
|
|||
| add_to_migration_reports(message=msg, category="Server Actions") | |||
|
|
|||
|
|
|||
| def update_custom_filter(cr, old, model, new=None): | |||
There was a problem hiding this comment.
- Bad function name.
- Not a fan of the magic
Nonevalue fornewfor the removal. What about passing a callback method? - follow the same pattern as other function and should iterate over inherits.
Suggested change
| def update_custom_filter(cr, old, model, new=None): | |
| def adapt_search_views(cr, old, model, callback, skip_inherit=()): |
There was a problem hiding this comment.
Can you please provide a reference for callback method, I didn't get it.
src/util/fields.py
Outdated
| WHERE {} ~ %s | ||
| AND type = 'search' | ||
| AND model = %s | ||
| AND active = 't' |
There was a problem hiding this comment.
Why only active views?
Suggested change
| AND active = 't' |
There was a problem hiding this comment.
I wanted to avoid False negative cases.
src/util/fields.py
Outdated
Comment on lines
1180
to
1184
| except lxml.etree.XMLSyntaxError as e: | ||
| if e.msg.startswith("Opening and ending tag mismatch"): | ||
| # this view is already wrong, we don't change it | ||
| _logger.warning("Skipping custom filter adaptaiton for invalid view (id=%s):\n%s", view_id, e.msg) | ||
| continue |
There was a problem hiding this comment.
Again, code copy/pasted from domains.py. Should be factorized.
thni-odoo
force-pushed
the
master-update_filter_context-thni
branch
2 times, most recently
from
5e83138 to
f48f3f5
Compare
This commit aims to make views compatible which are generated when a
search filter is created using studio, view looks like
<data>
<xpath expr="xyz" position="after">
<filter name="filter1" context="{'group_by': 'renamed field'}"/>
<filter name="filter2" context="{'group_by': 'removed field'}"/>
</xpath>
</data>
Currently after upgrade this view will be disabled because we are not updating
the field in this view.
After this fix
view:
<data>
<xpath expr="xyz" position="after">
<filter name="filter1" context="{'group_by': 'New Name'}"/>
<filter name="filter2" context="{}"/>
</xpath>
</data>
thni-odoo
force-pushed
the
master-update_filter_context-thni
branch
from
f48f3f5 to
585940d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to make views compatible which are generated when a search filter is created using studio, view looks like
Currently after upgrade this view will be disabled because we are not updating the field in this view.
After this fix
view:
Alternative upgrade PR
idk whether update_custom_filter is in correct file any suggestion where it should be ?