18.0 server tutorial frva by frva-odoo · Pull Request #737 · odoo/tutorials

frva-odoo · 2025-04-23T07:31:25Z

No description provided.

robodoo · 2025-04-23T07:31:28Z

naja628

Hello :) good work !

I left some comments on the code.

The little red things at the end of your files in the github ui are probably because you're missing end of line characters at the end of the last line. Your editor can probably be configured so it doesn't do that.

naja628 · 2025-04-23T08:09:01Z

@@ -0,0 +1,3 @@
+from . import models
+
+from odoo import api, SUPERUSER_ID


What are you trying to do with this line?

I pasted it from somewhere I found and forgot to see what it does ... I erased it for the next commit since it doesn't look mandatory

naja628 · 2025-04-23T08:22:43Z

+    name = fields.Char('Estate Name',required=True, translate=True)
+    description = fields.Text('Description')
+    postcode = fields.Char('Postcode')
+    date_availability = fields.Date('Date Availability', copy=False, default=fields.Date.add(fields.Date.today(),months=3))


Be careful for the default, if you do it this way fields.Date.today() will get evaled at the time where the class is evaled (so when odoo is started) instead of when we create a new record. default accepts lambda functions as well for this reason.

nitpick: for the label i think something like 'Date Available' or 'Availability Date' which is more natural-language-y would be better

naja628 · 2025-04-23T08:24:24Z

descriptive names please

naja628 · 2025-04-23T08:26:14Z

+    garden_area = fields.Integer('Garden Area')
+    garden_orientation = fields.Selection(string='Type', selection=[('north', 'North'), ('south', 'South'),('west', 'West'), ('east', 'East')])
+    active = fields.Boolean(default=True)
+    state = fields.Selection(required=True, copy=False, default='New', selection=[('New', 'New'), ('Offer Received', 'Offer Received'),('Offer Accepted', 'Offer Accepted'), ('Sold', 'Sold'), ('Cancelled', 'Cancelled')])


nitpick: usually we like the technical names of a selection to feel more code-like, so lower_snake_case

naja628 · 2025-04-24T13:29:29Z

+    name = fields.Char('Title', required=True, translate=True)
+    description = fields.Text('Description')
+    postcode = fields.Char('Postcode')
+    date_availability = fields.Date('Date Available', copy=False, default=lambda self: self._get_day_in_3_months())


Hello -- your answer to this #737 (comment) here is a bit redundant because you're both using a lambda and defining a fuction
You could either inline the functions return in the lambda or define the function above the fields and do default=_get_day_in_3_months.
By convention when we do the latter we usually name the function something like _default_<fieldname>

naja628 · 2025-04-24T13:32:04Z

@vava-odoo I'll let you take over here :)

vava-odoo

Good job! Just a few ( 👀 ) comments. Don't hesitate to ask if you have questions!

vava-odoo · 2025-04-28T10:46:06Z

@@ -0,0 +1,3 @@
+from . import estate_property
+from . import estate_property_type, estate_property_tag, estate_property_offer


Convention is one file imported at a time

vava-odoo · 2025-04-28T10:46:41Z

+from odoo import fields, models
+from odoo import api
+from odoo import exceptions


But nor here 😇
Also, we usually import UserError and ValidationError direclty

Suggested change

from odoo import fields, models

from odoo import api

from odoo import exceptions

from odoo import api, fields, models

from odoo.exceptions import UserError, ValidationError

vava-odoo · 2025-04-28T10:50:09Z

+    garden_area = fields.Integer('Garden Area')
+    garden_orientation = fields.Selection(string='Orientation Type', selection=[('north', 'North'), ('south', 'South'), ('west', 'West'), ('east', 'East')])
+    active = fields.Boolean(default=True)
+    state = fields.Selection(required=True, copy=False, default='new', selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])


A bit long... Suggestion:

Suggested change

state = fields.Selection(required=True, copy=False, default='new', selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])

state = fields.Selection(

required=True, copy=False, default='new',

selection=[

('new', 'New'),

('offer_received', 'Offer Received'),

('offer_accepted', 'Offer Accepted'),

('sold', 'Sold'),

('cancelled', 'Cancelled'),

],

)

vava-odoo · 2025-04-28T10:52:26Z

+         'The selling price must be positive.')
+    ]
+
+    @api.onchange("selling_price", "expected_price")


Why this onchange? You only want to constrain, don't you?

I thought it was necessary to be executed at each time the selling or expected price changes but I guess it's not then

vava-odoo · 2025-04-28T10:55:07Z

+
+    @api.depends("living_area", "garden_area")
+    def _compute_total_area(self):
+        self.total_area = self.living_area + self.garden_area


What if you edit several records at once?

vava-odoo · 2025-04-28T11:11:30Z

+            invoice_dictionary = {
+                "partner_id": record.buyer_id.id,
+                "move_type": "out_invoice",
+                "journal_id": self.env['account.journal'].search([("code", "=", "INV")]).id,


Why do you need a journal? What happen if there is none?
You could also add limit=1 to improve the perf

vava-odoo · 2025-04-28T11:13:21Z

+                ]
+            }
+            self.env["account.move"].create(invoice_dictionary)
+            super().action_sell_property()


You need to return super(), outside of the loop
Also, it would be interesting to call super first, to trigger the validation error if there is one before creating the invoice. It would be something like

Suggested change

super().action_sell_property()

res = super().action_sell_property()

for record in self:

...

return res

vava-odoo · 2025-04-28T11:13:55Z

+                    })
+                ]
+            }
+            self.env["account.move"].create(invoice_dictionary)


It would be best to batch create with a list of invoice values, outside of the loop on self.

vava-odoo · 2025-04-28T11:14:48Z

+        'estate',
+        'account'
+    ],
+    'data': [],


Empty, can be dropped

vava-odoo · 2025-04-28T11:15:08Z

Empty, not in manifest... Can be removed 🙂

vava-odoo · 2025-04-29T09:54:07Z

+        for val in invoice_values:
+            self.env["account.move"].create(val)


The purpose of my previous comment was to be able to create multiple invoices at once

Suggested change

for val in invoice_values:

self.env["account.move"].create(val)

self.env["account.move"].create(invoice_values)

naja628

Hello :) -- Good work !
I left some comments on the js tutorial

naja628 · 2025-05-02T13:58:57Z

+    static template = "Card";
+    static props = {
+        title: String,
+        slots: Object


Suggested change

slots: Object

slots: Object,

Also: could you make the slots optional so that something like below doesn't give an error?

<Card title='...'/>

naja628 · 2025-05-02T13:59:32Z

+    };
+
+    setup(){
+        this.state = useState( {open: true});


nitpick: inconsistent spacing

Suggested change

this.state = useState( {open: true});

this.state = useState({ open: true });

naja628 · 2025-05-02T14:09:58Z

+        if (this.props.onChange){
+            this.props.onChange()
+        }


tip: js syntactic sugar 🌈 (subjective -- it's ok to not like/use it)

Suggested change

if (this.props.onChange){

this.props.onChange()

}

this.props.onChange?.();

naja628 · 2025-05-02T14:11:04Z

+    increment(){
+        this.state.value++;
+        if (this.props.onChange){
+            this.props.onChange()


nitpick: inconsistent ; usage (do either always or never)

Suggested change

this.props.onChange()

this.props.onChange();

naja628 · 2025-05-02T14:14:44Z

+                <Counter onChange.bind="incrementSum"/>
+            </Card>
+            <Card title="'boring title'">
+                Some text egjpojges


segjopjge :)

naja628 · 2025-05-02T14:59:17Z

+         if (todoIdInArray >= 0) {
+             this.todos.splice(todoIdInArray, 1);
+         }


indentation

Suggested change

if (todoIdInArray >= 0) {

this.todos.splice(todoIdInArray, 1);

}

if (todoIdInArray >= 0) {

this.todos.splice(todoIdInArray, 1);

}

naja628 · 2025-05-02T15:00:09Z

+export function UseAutofocus(refString){
+    var myRef = useRef(refString);
+    onMounted(() => {
+        console.log(myRef.el)


left-over debug code

naja628 · 2025-05-02T15:04:44Z

+    }
+
+    removeTodo(todoId){
+        var todoIdInArray = this.todos.findIndex((todo) => todo.id == todoId);


Suggested change

var todoIdInArray = this.todos.findIndex((todo) => todo.id == todoId);

const todoIdInArray = this.todos.findIndex((todo) => todo.id == todoId);

never use var; prefer const over let when possible

naja628 · 2025-05-02T15:05:35Z

+
+
+export function UseAutofocus(refString){
+    var myRef = useRef(refString);


Suggested change

var myRef = useRef(refString);

const myRef = useRef(refString);

also myRef could use a better name

naja628 · 2025-05-02T15:06:55Z

+            type: 'ir.actions.act_window',
+            name: 'All leads',
+            res_model: 'crm.lead',
+            views: [[false, 'list'],[false, 'form']],


Suggested change

views: [[false, 'list'],[false, 'form']],

views: [[false, 'list'], [false, 'form']],

or evn

Suggested change

views: [[false, 'list'],[false, 'form']],

views: [

[false, 'list'],

[false, 'form'],

],

…eported issues

…ms (10_11)

vava-odoo

Data module looks great until now 👍

vava-odoo · 2025-05-07T07:37:37Z

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+


vava-odoo · 2025-05-07T07:37:52Z

@@ -0,0 +1 @@
+from . import models


Nothing in the init

Suggested change

from . import models

vava-odoo · 2025-05-07T07:39:47Z

+        <field name="sequence">1</field>
+    </record>
+
+    <record id="selection_real_estate_property_garden_orientation" model="ir.model.fields.selection">


same ID as previous one, will edit it instead of creating a new one...

Suggested change

<record id="selection_real_estate_property_garden_orientation" model="ir.model.fields.selection">

<record id="selection_real_estate_property_garden_orientation_south" model="ir.model.fields.selection">

vava-odoo

Good good 🙂

vava-odoo · 2025-05-07T11:07:10Z

+                            <group>
+                                <field name="x_offer_ids"/>
+                            </group>


Do you need a group here?

vava-odoo · 2025-05-07T12:32:08Z

+    property['x_total_area'] = property.x_living_area + property.x_garden_area
+        ]]>
+        </field>
+        <field name="readonly">True</field>


not sure we want to store that field

vava-odoo · 2025-05-07T12:33:44Z

        <field name="on_delete">restrict</field>
    </record>
+
+    <record id="action_real_estate_property_offer_accept_offer" model="ir.actions.server">


Instead/on addition to a button, it could make sense to bind this as well, so that it is available from the gear

vava-odoo · 2025-05-07T12:35:06Z

+        <field name="state">code</field>
+        <field name="code"><![CDATA[
+    for offer in records:
+        for property_offer in offer['x_property_id']['x_offer_ids']:


The Python ORM way of writing works for this reading case (I personally find it easier to read)

Suggested change

for property_offer in offer['x_property_id']['x_offer_ids']:

for property_offer in offer.x_property_id.x_offer_ids:

vava-odoo · 2025-05-07T12:36:16Z

+        for property_offer in offer['x_property_id']['x_offer_ids']:
+            property_offer['x_status'] = 'refused'
+        offer['x_status'] = 'accepted'
+        offer['x_property_id']['x_partner_id'] = offer['x_partner_id']


Not sure about this way of writing

vava-odoo · 2025-05-07T12:40:03Z

+    'name': 'frva-estate-account',
+    'license': 'LGPL-3',
+    'depends': [
+        'estate',


🤷

Suggested change

'estate',

'estate_classic',

vava-odoo · 2025-05-07T15:46:00Z

-
+    <record id="real_estate_property_public_users_write_record_rule" model="ir.rule">
+        <field name="name">Public users cannot modify a real estate property</field>
+        <field ref="estate.model_real_estate_property" name="model_id"/>


Had to read it twice 😅

Suggested change

<field ref="estate.model_real_estate_property" name="model_id"/>

<field name="model_id" ref="estate.model_real_estate_property"/>

vava-odoo · 2025-05-07T15:46:24Z

+        <field name="domain_force">[('id', '=', False)]</field>
+        <field name="groups" eval="[(4, ref('base.group_public'))]"/>
+        <field name="perm_write" eval="False"/>
+        <field name="active" eval="False"/>


Why not active?

vava-odoo · 2025-05-09T14:20:46Z

+        self.property.state = 'sold'
+        with self.assertRaises(UserError):
+            self.offer = self.env['estate_classic.property.offer'].create({
+                "property_id": self.property,


Suggested change

"property_id": self.property,

"property_id": self.property.id,

vava-odoo · 2025-05-09T14:21:02Z

+                }),
+            }).id


Suggested change

}),

}).id

}).id,

})

vava-odoo · 2025-05-09T14:21:22Z

+            }),
+        }).id


Suggested change

}),

}).id

}).id,

})

vava-odoo

Only small comments about tests :-)

vava-odoo · 2025-05-09T14:25:21Z

+            }),
+        }).id
+        self.property.offer_ids = [self.offer]
+        self.offer.action_accept_offer()


You accept an offer without price 😯

I'll add it !

vava-odoo · 2025-05-09T14:26:00Z

+from odoo.tests import tagged
+
+
+@tagged('at_install')


No need as default one

Suggested change

@tagged('at_install')

vava-odoo · 2025-05-09T16:45:36Z

+class EstateOfferTestCase(TransactionCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.property = cls.env['estate_classic.property'].create({
+            "name": "Cool House",
+            "state": 'new',
+            "expected_price": 100000,
+        })


The setup is the same between both test classes, you can inherit then

Suggested change

class EstateOfferTestCase(TransactionCase):

@classmethod

def setUpClass(cls):

super().setUpClass()

cls.property = cls.env['estate_classic.property'].create({

"name": "Cool House",

"state": 'new',

"expected_price": 100000,

})

class EstateOfferTestCase(EstateTestCase):

Is there no problem like duplicate function when we do that ? Because the parent's function will also be inherited no ?

vava-odoo · 2025-05-09T16:46:10Z

+                "partner_id": self.env['res.partner'].create({
+                    'name': 'partner_a',
+                }).id,


Could be worth to create the partner in the setup, since you use 3 times.

vava-odoo · 2025-05-09T16:47:27Z

+                'name': 'partner_a',
+            }).id,
+        })
+        self.property.offer_ids = [self.offer.id]


Useless, since you already linked the property to the offer

Suggested change

self.property.offer_ids = [self.offer.id]

naja628 reviewed Apr 23, 2025

View reviewed changes

naja628 reviewed Apr 24, 2025

View reviewed changes

vava-odoo reviewed Apr 28, 2025

View reviewed changes

frva-odoo added 12 commits April 28, 2025 13:44

[IMP] estate: End of chapter 4 commit

c12884e

[IMP] estate: End of Chapter 5

d7696ab

[IMP] estate: End of chapter 6

8c00a6e

[FIX] estate: Clean code and correction of reported issues

4c39311

[IMP] estate: End of chapter 7

6f18a4b

[IMP] estate: End of day 2

438818c

[IMP] estate: End of chapter 8

dbbf98e

[IMP] estate: End of chapter 9

d1cf2bc

[IMP] estate: End of chapter 11

ecd1179

[IMP] estate: End of chapter 12

d9ff057

[ADD] estate_account: end of tutorial chapter 13

10d9c53

[IMP] estate: End of tutorial chapter 14

0475bd5

frva-odoo force-pushed the 18.0-server-tutorial-frva branch from f9b9613 to 0475bd5 Compare April 28, 2025 11:47

[FIX] estate,estate_account: Correction of issues

dda9737

frva-odoo force-pushed the 18.0-server-tutorial-frva branch from 265d728 to dda9737 Compare April 29, 2025 06:49

vava-odoo reviewed Apr 29, 2025

View reviewed changes

frva-odoo added 7 commits April 29, 2025 16:13

[IMP] awesome_owl: component, subcomponent and props

4f9e253

[IMP] awesome_owl: markup, props validation and callback prop

89d84e7

[IMP] awesome_owl: todo, dynamic attributes and adding todos

7dd734d

[IMP] awesome_owl: focusing input, togglin and deleting todos

5c6eb35

[IMP] awesome_owl: generic cards and minimizing

3f63141

[IMP] awesome_dashboard: a new layout

ea5a464

[IMP] awesome_dashboard: Add some buttons for quick navigation (2)

d48b0ae

naja628 reviewed May 2, 2025

View reviewed changes

[IMP] awesome_dashboard: Add a dashboard item (3)

5a12840

frva-odoo added 7 commits May 2, 2025 21:27

[FIX] awesome_owl, awesome_dashboard, estate_account: correction of r…

1b8a7ab

…eported issues

[IMP] awesome_dashboard: Call the server, add some statistics (4)

312a82b

[IMP] awesome_dashboard: Cache, Pie Chart and Real life update (5_6_7)

a0c1f27

[IMP] awesome_dashboard: Lazy loading and generic dashboard(8_9)

8716e47

[IMP] awesome_dashboard: Extensible Dashboard and Adding/Removing Ite…

98e2e48

…ms (10_11)

[ADD] estate: Model, fields, security and views

74d287b

[IMP] estate: form view

627a455

vava-odoo reviewed May 7, 2025

View reviewed changes

frva-odoo added 2 commits May 7, 2025 11:33

[IMP] estate: property types, tags and offers (m2o,m2m,o2m)

8ad0af2

[IMP] estate: accept offer (server actions)

753c206

vava-odoo reviewed May 7, 2025

View reviewed changes

frva-odoo added 3 commits May 7, 2025 17:10

[IMP] estate: website controllers

89687de

[IMP] estate: Adding simple tour and adding basic demo data

bc02bef

[IMP] estate_classic: tests implementation (not working)

cd23057

vava-odoo reviewed May 9, 2025

View reviewed changes

[IMP] estate_classic: tests implementation (now working)

a862e0a

vava-odoo reviewed May 9, 2025

View reviewed changes

[FIX] estate_classic: Code optimization

a33c705

		@@ -0,0 +1,3 @@
		from . import models

		from odoo import api, SUPERUSER_ID No newline at end of file

		@@ -0,0 +1,3 @@
		from . import estate_property
		from . import estate_property_type, estate_property_tag, estate_property_offer

-            super().action_sell_property()
+            res = super().action_sell_property()
+            for record in self:
+                ...
+            return res

		for val in invoice_values:
		self.env["account.move"].create(val)

	for val in invoice_values:
	self.env["account.move"].create(val)
	self.env["account.move"].create(invoice_values)

	this.state = useState( {open: true});
	this.state = useState({ open: true });

	var todoIdInArray = this.todos.findIndex((todo) => todo.id == todoId);
	const todoIdInArray = this.todos.findIndex((todo) => todo.id == todoId);



		export function UseAutofocus(refString){
		var myRef = useRef(refString);

	var myRef = useRef(refString);
	const myRef = useRef(refString);

	views: [[false, 'list'],[false, 'form']],
	views: [[false, 'list'], [false, 'form']],

	<record id="selection_real_estate_property_garden_orientation" model="ir.model.fields.selection">
	<record id="selection_real_estate_property_garden_orientation_south" model="ir.model.fields.selection">

	for property_offer in offer['x_property_id']['x_offer_ids']:
	for property_offer in offer.x_property_id.x_offer_ids:

	<field ref="estate.model_real_estate_property" name="model_id"/>
	<field name="model_id" ref="estate.model_real_estate_property"/>

	"property_id": self.property,
	"property_id": self.property.id,

-                }),
-            }).id
+                }).id,
+            })

Uh oh!

Conversation

frva-odoo commented Apr 23, 2025

Uh oh!

robodoo commented Apr 23, 2025

Uh oh!

naja628 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frva-odoo Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naja628 commented Apr 24, 2025

Uh oh!

vava-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naja628 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naja628 May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naja628 May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naja628 left a comment •

edited

Loading

frva-odoo Apr 23, 2025 •

edited

Loading

vava-odoo left a comment •

edited

Loading

naja628 left a comment •

edited

Loading

naja628 May 2, 2025 •

edited

Loading

naja628 May 2, 2025 •

edited

Loading